代码优化

sop-business/src/main/java/com/qmth/sop/business/service/impl/SysNoticeServiceImpl.java

@@ -20,8 +20,11 @@ import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 import javax.annotation.Resource;
+import java.util.Arrays;
+import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.stream.Collectors;
 
 /**
  * 公告表 服务实现.
@@ -104,20 +107,19 @@ public class SysNoticeServiceImpl extends ServiceImpl<SysNoticeMapper, SysNotice
     @Override
     @Transactional
     public boolean disable(long[] ids) {
-//        List<SysNotice> sysNotices=new ArrayList<>();
-        for (long id : ids) {
-            SysNotice sysNotice = this.getById(id);
-            sysNotice.setEnable(false);
-            if (NoticeStatusEnum.PUBLISH == sysNotice.getStatus()) {
-                sysNotice.setStatus(NoticeStatusEnum.UN_PUBLISH);
+        //ids数组转化为list
+        List<Long> idList = Arrays.stream(ids).boxed().collect(Collectors.toList());
+        //根据id数组查询公告表
+        List<SysNotice> sysNotices = this.listByIds(idList);
+        sysNotices.forEach(e->{
+            e.setEnable(false);
+            if (NoticeStatusEnum.PUBLISH == e.getStatus()) {
+                e.setStatus(NoticeStatusEnum.UN_PUBLISH);
                 // 需调用撤销发布SysMessage
-                sysMessageService.deleteByNoticeId(id);
+                sysMessageService.deleteByNoticeId(e.getId());
             }
-//            sysNotices.add(sysNotice);
-            this.saveOrUpdate(sysNotice);
-        }
-//        this.updateBatchById(sysNotices);
-        return true;
+        });
+        return this.updateBatchById(sysNotices);
     }
 
     @Override

sop-business/src/main/java/com/qmth/sop/business/service/impl/TBQualityProblemApplyServiceImpl.java

@@ -19,10 +19,8 @@ import org.springframework.transaction.annotation.Transactional;
 
 import javax.annotation.Resource;
 import javax.servlet.http.HttpServletRequest;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Objects;
-import java.util.Set;
+import java.util.*;
+import java.util.stream.Collectors;
 
 /**
  * 质量问题反馈表 服务实现.
@@ -89,10 +87,8 @@ public class TBQualityProblemApplyServiceImpl extends ServiceImpl<TBQualityProbl
     @Override
     @Transactional
     public Boolean delete(long[] ids) {
-        for (long id : ids) {
-            this.removeById(id);
-        }
-        return true;
+        List<Long> idList = Arrays.stream(ids).boxed().collect(Collectors.toList());
+        return this.removeByIds(idList);
     }
 
 }