just format codes.

examcloud-exchange-api-provider/src/main/java/cn/com/qmth/examcloud/exchange/inner/api/provider/SmsCloudServiceProvider.java

@@ -18,8 +18,6 @@ import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.bind.annotation.RestController;
 
 import javax.validation.Valid;
-import java.util.List;
-import java.util.Map;
 
 /**
  * 短信发送
@@ -36,35 +34,24 @@ public class SmsCloudServiceProvider extends ControllerSupport implements SmsClo
     @Override
     @RequestMapping(method = RequestMethod.POST, value = "sendSms")
     public SendSmsResp sendSms(@RequestBody @Valid @ApiParam(required = true) SendSmsReq req) {
-
-        String smsAssemblyCode = req.getSmsAssemblyCode();
-        List<String> phoneList = req.getPhoneList();
-        Map<String, String> params = req.getParams();
-
-        smsService.sendSms(smsAssemblyCode, phoneList, params);
-
-        SendSmsResp resp = new SendSmsResp();
-        return resp;
+        smsService.sendSms(req.getSmsAssemblyCode(), req.getPhoneList(), req.getParams());
+        return new SendSmsResp();
     }
 
     @Override
     @WithoutStackTrace
     @RequestMapping(method = RequestMethod.POST, value = "sendSmsCode")
-    public SendSmsCodeResp sendSmsCode(
-            @RequestBody @Valid @ApiParam(required = true) SendSmsCodeReq req) {
+    public SendSmsCodeResp sendSmsCode(@RequestBody @Valid @ApiParam(required = true) SendSmsCodeReq req) {
         smsService.sendSmsCode(req.getPhone(), req.getCode());
-        SendSmsCodeResp sendSmsResp = new SendSmsCodeResp();
-        return sendSmsResp;
+        return new SendSmsCodeResp();
     }
 
     @Override
     @WithoutStackTrace
     @RequestMapping(method = RequestMethod.POST, value = "checkSmsCode")
-    public CheckSmsCodeResp checkSmsCode(
-            @RequestBody @Valid @ApiParam(required = true) CheckSmsCodeReq req) {
+    public CheckSmsCodeResp checkSmsCode(@RequestBody @Valid @ApiParam(required = true) CheckSmsCodeReq req) {
         smsService.validateSmsCode(req.getPhone(), req.getCode());
-        CheckSmsCodeResp resp = new CheckSmsCodeResp();
-        return resp;
+        return new CheckSmsCodeResp();
     }
 
 }

examcloud-exchange-service/src/main/java/cn/com/qmth/examcloud/exchange/inner/service/SmsService.java

@@ -5,11 +5,6 @@ import java.util.Map;
 
 public interface SmsService {
 
-    /**
-     * 验证码配置代码
-     */
-    String YZM_SMS_ASSEMBLY_CODE = "YZM";
-
     /**
      * 发送短信
      *

examcloud-exchange-service/src/main/java/cn/com/qmth/examcloud/exchange/inner/service/impl/SmsServiceImpl.java

@@ -2,26 +2,16 @@ package cn.com.qmth.examcloud.exchange.inner.service.impl;
 
 import cn.com.qmth.examcloud.commons.exception.StatusException;
 import cn.com.qmth.examcloud.commons.util.DateUtil;
-import cn.com.qmth.examcloud.commons.util.JsonUtil;
 import cn.com.qmth.examcloud.commons.util.UUID;
 import cn.com.qmth.examcloud.exchange.inner.service.SmsService;
 import cn.com.qmth.examcloud.exchange.inner.service.bean.ShortMessageInfo;
 import cn.com.qmth.examcloud.support.CacheConstants;
 import cn.com.qmth.examcloud.support.cache.CacheHelper;
 import cn.com.qmth.examcloud.support.cache.bean.SmsAssemblyCacheBean;
+import cn.com.qmth.examcloud.support.sms.SmsHelper;
 import cn.com.qmth.examcloud.web.bootstrap.PropertyHolder;
 import cn.com.qmth.examcloud.web.redis.RedisClient;
-import com.aliyuncs.CommonRequest;
-import com.aliyuncs.CommonResponse;
-import com.aliyuncs.DefaultAcsClient;
-import com.aliyuncs.IAcsClient;
-import com.aliyuncs.http.MethodType;
-import com.aliyuncs.http.ProtocolType;
-import com.aliyuncs.profile.DefaultProfile;
 import com.google.common.collect.Maps;
-import com.google.gson.JsonObject;
-import com.google.gson.JsonParser;
-import org.apache.tomcat.util.buf.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -33,40 +23,35 @@ import java.util.List;
 import java.util.Map;
 
 /**
- * {@link StatusException} 状态码范围：101XXX<br>
- * <p>
- * 阿里云短信服务
+ * 短信发送
  *
  * @author WANGWEI
  * @date 2019年3月27日
- * @Copyright (c) 2018-? http://qmth.com.cn All Rights Reserved.
  */
 @Service
 public class SmsServiceImpl implements SmsService {
 
-    @Autowired
-    RedisClient redisClient;
+    private static final Logger log = LoggerFactory.getLogger(SmsServiceImpl.class);
 
-    private static final Logger LOG = LoggerFactory.getLogger(SmsServiceImpl.class);
+    @Autowired
+    private RedisClient redisClient;
 
     @Override
-    public void sendSms(String smsAssemblyCode, List<String> phoneList,
-                        Map<String, String> params) {
+    public void sendSms(String smsAssemblyCode, List<String> phoneList, Map<String, String> params) {
         SmsAssemblyCacheBean smsAssembly = CacheHelper.getSmsAssembly(smsAssemblyCode);
         if (null == smsAssembly) {
             throw new StatusException("101040", "smsAssemblyCode is wrong");
         }
+
         boolean virtualEnable = PropertyHolder.getBoolean("sms.virtual.enable", false);
         if (!virtualEnable) {
-            execute(smsAssembly, "SendSms", phoneList, params);
+            SmsHelper.send(smsAssembly.getExt1(), smsAssembly.getExt2(), phoneList, params);
         }
     }
 
     @Override
     public void sendSmsCode(String phone, String code) {
-
         boolean virtualEnable = PropertyHolder.getBoolean("sms.smsCode.virtual.enable", false);
-
         if (virtualEnable) {
             return;
         }
@@ -82,7 +67,6 @@ public class SmsServiceImpl implements SmsService {
         }
 
         Date now = new Date();
-
         if (null == sm) {
             sm = new ShortMessageInfo();
             sm.setCreationTime(now);
@@ -107,7 +91,7 @@ public class SmsServiceImpl implements SmsService {
         }
         Map<String, String> params = Maps.newHashMap();
         params.put("code", code);
-        this.sendSms(YZM_SMS_ASSEMBLY_CODE, Arrays.asList(new String[]{phone}), params);
+        this.sendSms(SmsHelper.SMS_YZM, Arrays.asList(new String[]{phone}), params);
 
         sm.getSendTimeList().add(now);
         sm.setTimes(sm.getSendTimeList().size());
@@ -118,7 +102,6 @@ public class SmsServiceImpl implements SmsService {
 
     @Override
     public void validateSmsCode(String phone, String code) {
-
         boolean virtualEnable = PropertyHolder.getBoolean("sms.smsCode.virtual.enable", false);
 
         if (virtualEnable) {
@@ -150,56 +133,6 @@ public class SmsServiceImpl implements SmsService {
             sm.setLastMessage(UUID.randomUUID());
             redisClient.set(key, sm, 60 * 60 * 24);
         }
-
-    }
-
-    /**
-     * 执行
-     *
-     * @param smsAssembly
-     * @param action
-     * @param phoneList
-     * @param templateParams 短信模板参数
-     * @author WANGWEI
-     */
-    private void execute(SmsAssemblyCacheBean smsAssembly, String action, List<String> phoneList,
-                         Map<String, String> templateParams) {
-        String accessKeyId = PropertyHolder.getString("aliyun.sms.accessKeyId");
-        String accessSecret = PropertyHolder.getString("aliyun.sms.accessKeySecret");
-        String signName = smsAssembly.getExt1();
-        String templateCode = smsAssembly.getExt2();
-
-        DefaultProfile profile = DefaultProfile.getProfile("default", accessKeyId, accessSecret);
-        IAcsClient client = new DefaultAcsClient(profile);
-
-        CommonRequest request = new CommonRequest();
-        request.setProtocol(ProtocolType.HTTPS);
-        request.setMethod(MethodType.POST);
-        request.setDomain("dysmsapi.aliyuncs.com");
-        request.setVersion("2017-05-25");
-        request.setAction(action);
-        String phoneNumbers = StringUtils.join(phoneList, ',');
-        request.putQueryParameter("PhoneNumbers", phoneNumbers);
-        request.putQueryParameter("SignName", signName);
-        request.putQueryParameter("TemplateCode", templateCode);
-        request.putQueryParameter("TemplateParam", JsonUtil.toJson(templateParams));
-        try {
-            CommonResponse response = client.getCommonResponse(request);
-            String data = response.getData();
-            JsonParser jp = new JsonParser();
-            JsonObject jsonObj = jp.parse(data).getAsJsonObject();
-            String code = jsonObj.get("Code").getAsString();
-
-            if (!code.equals("OK")) {
-                LOG.error("aliyun sms response: " + JsonUtil.toJson(response));
-                throw new StatusException("101001", "短信发送失败");
-            }
-
-        } catch (StatusException e) {
-            throw e;
-        } catch (Exception e) {
-            throw new StatusException("101002", "短信发送失败", e);
-        }
     }
 
 }