소스 검색

修复版本新增/修改权限判断bug

luoshi 2 년 전
부모
커밋
694a739c61

+ 1 - 1
src/main/java/com/qmth/ops/api/controller/admin/DeployController.java

@@ -110,7 +110,7 @@ public class DeployController {
 
     @PostMapping("/device/delete")
     public Object deleteDevice(@RequestAttribute AdminSession adminSession, @RequestParam Long id,
-            @RequestParam String deviceId) throws Exception {
+            @RequestParam String deviceId) {
         adminSession.hasPermission(Permission.DEPLOY_DEVICE_EDIT, id);
         Deploy deploy = deployService.findById(id);
         if (deploy != null) {

+ 4 - 3
src/main/java/com/qmth/ops/api/controller/admin/VersionController.java

@@ -33,13 +33,14 @@ public class VersionController {
     @PostMapping("/insert")
     public Version insert(@RequestAttribute AdminSession adminSession, @RequestParam Long appId,
             @RequestParam VersionNumber name) {
-        adminSession.hasPermission(Permission.VERSION_INSERT);
+        adminSession.hasPermission(Permission.VERSION_INSERT, appId);
         return versionService.insert(appService.getById(appId), name);
     }
 
     @PostMapping("/update")
-    public Version list(@RequestAttribute AdminSession adminSession, Version version) {
-        adminSession.hasPermission(Permission.VERSION_EDIT);
+    public Version edit(@RequestAttribute AdminSession adminSession, Version version) {
+        Version previous = versionService.getById(version.getId());
+        adminSession.hasPermission(Permission.VERSION_EDIT, previous.getAppId());
         return versionService.update(version);
     }